Add an example for encrypting payloads.#82
Merged
robholland merged 6 commits intotemporalio:masterfrom Apr 14, 2021
Merged
Conversation
mfateev
reviewed
Mar 18, 2021
mfateev
reviewed
Mar 18, 2021
mfateev
reviewed
Mar 29, 2021
| } | ||
|
|
||
| @Override | ||
| public Optional<Payloads> toPayloads(Object... values) throws DataConverterException { |
Member
There was a problem hiding this comment.
I would call converter.toPayloads(values) and then serialize the resulting Payload (using protobuf generated method) and then encrypt the whole thing at once.
Contributor
Author
There was a problem hiding this comment.
This didn't quite feel safe to me as Payloads has no metadata. I have however taken the suggestion of encrypting/decrypting the serialised payload rather than encrypting only the data. This is much cleaner now :)
mfateev
reviewed
Apr 12, 2021
This allows key rotation to be used.
vitarb
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.